Improve handling of "dtype" arguments in OpSchema/OpSpec #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prak-nv
approved these changes
Jun 13, 2022
…ck ambiguous overload of AddOptionalArg with a static_assert. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Don't pass "dtype" to warp_affine when it's the same as input - let the operator infer the type. Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
CI MESSAGE: [5072940]: BUILD STARTED |
|
CI MESSAGE: [5072940]: BUILD FAILED |
Signed-off-by: Michał Zientkiewicz <mzient@gmail.com>
|
CI MESSAGE: [5073962]: BUILD STARTED |
|
CI MESSAGE: [5073962]: BUILD FAILED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
commented
Jun 14, 2022
| @@ -244,7 +261,7 @@ def test_gpu_vs_cpu(): | |||
| inv_map=inv_map) | |||
| gpu_pipeline.build() | |||
|
|
|||
| compare(cpu_pipeline, gpu_pipeline, 1) | |||
| compare(cpu_pipeline, gpu_pipeline, 1.0001) | |||
There was a problem hiding this comment.
The new fill value results in max differences slightly >1 (rounding + some error accumulation, likely result of using fma on GPU and plain mul/add on CPU).
|
CI MESSAGE: [5079728]: BUILD STARTED |
|
CI MESSAGE: [5079728]: BUILD PASSED |
prak-nv
approved these changes
Jun 14, 2022
jantonguirao
approved these changes
Jun 14, 2022
| out_of_bounds_policy_(GetOutOfBoundsPolicy(spec)) { | ||
| spec.TryGetArgument(output_type_, "dtype"); |
There was a problem hiding this comment.
Have you checked there's a default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michał Zientkiewicz mzient@gmail.com
Category:
Bug fix (non-breaking change which fixes an issue)
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
Bug:
removing a default value from
AddOptionalArg("name", "doc", value, TYPE_ID)resulted in adding an argument of type DALIDataType and the default value TYPE_ID. This happened in "fill_value" argument to WarpAttr. This PR fixes that.Refactoring:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Existing tests: all over the place
New tests: test_operator_warp - added floating point fill value
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A