Reduce DALI conda package installation time #3995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [5136988]: BUILD STARTED |
JanuszL
changed the title
|
CI MESSAGE: [5138198]: BUILD STARTED |
mzient
changed the title
mzient
reviewed
Jun 21, 2022
| - libprotobuf-static >=3.18.0 | ||
| - libjpeg-turbo >=2.1.1 | ||
| - future | ||
| - protobuf |
There was a problem hiding this comment.
Hmmm... actually, while touching this one - shouldn't we require <4 ? There were some serious issues with protobuf 4.
There was a problem hiding this comment.
We link it statically and we are fine with any version. The problem is with TF compiled with one version and used with other.
mzient
approved these changes
Jun 21, 2022
|
CI MESSAGE: [5136988]: BUILD FAILED |
|
CI MESSAGE: [5136988]: BUILD PASSED |
|
CI MESSAGE: [5138198]: BUILD PASSED |
stiepan
approved these changes
Jun 22, 2022
JanuszL
added a commit
that referenced
this pull request
Jun 22, 2022
- reduces DALI conda package installation time by loosing the package dependency constrains Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
constrains
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
constrains
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A