Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Numba GPU op for incompatible Numba versions #4025

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

awolant
Copy link
Contributor

@awolant awolant commented Jun 29, 2022

Category:

Bug Fix

Description:

Current implementation of the Numba GPU op is incompatible with old Numba versions. This PR introduces the check to the __init__ method to raise an exception with relevant information about required and current versions of Numba.

Tests are skipped for incompatible Numba.

Additional information:

Affected modules and functionalities:

Numba GPU operator and its tests.

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
@awolant
Copy link
Contributor Author

awolant commented Jun 29, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [5210985]: BUILD STARTED

@awolant awolant changed the title Fix numba missing driver api Disable Numba GPU op for incompatible Numba versions Jun 29, 2022
@klecki klecki self-assigned this Jun 29, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [5210985]: BUILD PASSED

@JanuszL JanuszL self-assigned this Jun 29, 2022
@awolant awolant merged commit efdec48 into NVIDIA:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants