-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable nose2 in Python Tests #4033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
!build |
CI MESSAGE: [5250792]: BUILD STARTED |
CI MESSAGE: [5250792]: BUILD FAILED |
!build |
CI MESSAGE: [5251176]: BUILD STARTED |
szalpal
approved these changes
Jul 4, 2022
CI MESSAGE: [5251176]: BUILD FAILED |
Signed-off-by: Albert Wolant <awolant@nvidia.com>
!build |
CI MESSAGE: [5251900]: BUILD STARTED |
CI MESSAGE: [5251900]: BUILD PASSED |
prak-nv
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New Feature
Description:
nose2
package to the list of packages installed in tests.operator
in Python tests directory since nose2 can handle directory based tests discovery. We no longer have to depend on filtering tests names in bash scripts to run subsets of tests.operator
directory.Additional information:
Affected modules and functionalities:
Python tests and bash scripts related to how we run Python tests.
Key points relevant for the review:
Didn't I miss any test during the transition? Is everything that was tested with nose is tested with nose2.
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2872