Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable nose2 in Python Tests #4033

Merged
merged 6 commits into from
Jul 6, 2022

Conversation

awolant
Copy link
Contributor

@awolant awolant commented Jul 4, 2022

Category:

New Feature

Description:

  • Enabled nose2 in Python Tests.
  • Added nose2 package to the list of packages installed in tests.
  • Added nose2 configuration file to main Python tests directory. This file will be used to enable nose2 plugins.
  • Created new directory operator in Python tests directory since nose2 can handle directory based tests discovery. We no longer have to depend on filtering tests names in bash scripts to run subsets of tests.
  • One test file was copied to this new directory. Only changes to it were to remove unused code. Otherwise it is the same as the old test. Removed operator from the test file name since now it loves in operator directory.

Additional information:

Affected modules and functionalities:

Python tests and bash scripts related to how we run Python tests.

Key points relevant for the review:

Didn't I miss any test during the transition? Is everything that was tested with nose is tested with nose2.

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-2872

Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
Signed-off-by: Albert Wolant <awolant@nvidia.com>
@awolant
Copy link
Contributor Author

awolant commented Jul 4, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [5250792]: BUILD STARTED

@szalpal szalpal self-assigned this Jul 4, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [5250792]: BUILD FAILED

Signed-off-by: Albert Wolant <awolant@nvidia.com>
@awolant
Copy link
Contributor Author

awolant commented Jul 4, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [5251176]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [5251176]: BUILD FAILED

Signed-off-by: Albert Wolant <awolant@nvidia.com>
@awolant
Copy link
Contributor Author

awolant commented Jul 4, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [5251900]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [5251900]: BUILD PASSED

@awolant awolant merged commit 01457a1 into NVIDIA:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants