Move audio_resample out of experimental module
#4194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
commented
Aug 25, 2022
| @@ -96,6 +96,17 @@ type. Example:: | |||
| )", | |||
| nullptr, false); | |||
|
|
|||
| // Deprecated alias | |||
| DALI_SCHEMA(experimental__AudioResample) | |||
There was a problem hiding this comment.
Note to reviewers: Please look at the rendered documentation too, when available
|
!build |
|
CI MESSAGE: [5743303]: BUILD STARTED |
|
CI MESSAGE: [5743303]: BUILD FAILED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [5744482]: BUILD STARTED |
|
CI MESSAGE: [5744482]: BUILD PASSED |
klecki
reviewed
Aug 26, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
klecki
reviewed
Aug 26, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
CI MESSAGE: [5754688]: BUILD STARTED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
klecki
reviewed
Aug 26, 2022
klecki
approved these changes
Aug 26, 2022
|
!build |
|
CI MESSAGE: [5754763]: BUILD STARTED |
|
CI MESSAGE: [5754763]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Category:
Refactoring / Other (deprecation/rename)
Description:
fn.experimental.audio_resamplein favor offn.audio_resample.Additional information:
Affected modules and functionalities:
audio_resample
Key points relevant for the review:
NA
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A