Improve error handling in LibTiffDecoder #4210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
mzient
reviewed
Sep 19, 2022
Comment on lines
259
to
260
| DecodeResult LibTiffDecoderInstance::Decode(SampleView<CPUBackend> out, ImageSource *in, | ||
| DecodeParams opts, const ROI &requested_roi) { |
There was a problem hiding this comment.
This is already out of date due to API changes. Also, please implement DecodeTaskImpl nistead of DecodeImpl, as it is required by ScheduleDecode.
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
tiff-error
branch
from
f0dade1
to
47792e3
Compare
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
tiff-error
branch
from
47792e3
to
81bea7d
Compare
mzient
reviewed
Sep 20, 2022
| @@ -114,10 +114,12 @@ struct TiffInfo { | |||
| uint16_t bit_depth; | |||
| uint16_t orientation; | |||
| uint16_t compression; | |||
| uint16_t photometric; | |||
There was a problem hiding this comment.
Nitpick: the name sounds as if it's a boolean predicate - I'd expect a noun.
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [5958401]: BUILD STARTED |
mzient
approved these changes
Sep 20, 2022
szalpal
approved these changes
Sep 20, 2022
|
CI MESSAGE: [5958401]: BUILD PASSED |
staniewzki
pushed a commit
to staniewzki/DALI
that referenced
this pull request
Sep 21, 2022
While testing LibTiffDecoder, I've identified two major problems with error handling there: Corrupted (or exotic, unsupported) files will cause an exception, which would kill the pipeline. In this PR I add a bulk catch to gracefully handle those and allow for a fallback instead of killing the pipeline Not enough checks were made at the beginning and as a result TIFFs that we couldn't decode correctly (planar or with non-standard photometric interpretation) were not rejected. In this PR I add checks for those Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
While testing LibTiffDecoder, I've identified two major problems with error handling there:
catchto gracefully handle those and allow for a fallback instead of killing the pipelineAdditional information:
Affected modules and functionalities:
LibTiffDecoder
Key points relevant for the review:
Tests:
I added an extra test with an incomplete input, which should cause
InputStreamto throw an exception.Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-2981