Presteps needed by image_decoder.h APIs #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzient
approved these changes
Sep 23, 2022
jantonguirao
force-pushed
the
ImageDecoderPresteps
branch
from
17c45e1
to
fd67eeb
Compare
|
!build |
|
CI MESSAGE: [5992476]: BUILD STARTED |
jantonguirao
force-pushed
the
ImageDecoderPresteps
branch
from
fd67eeb
to
847abdb
Compare
|
CI MESSAGE: [5992476]: BUILD PASSED |
jantonguirao
commented
Sep 23, 2022
| } catch (...) { | ||
| res.exception = std::current_exception(); | ||
| res.success = false; | ||
| auto decoded_image = jpeg::Uncompress(encoded_data, data_size, flags); |
There was a problem hiding this comment.
removed try/catch (handled one layer up)
jantonguirao
commented
Sep 23, 2022
| res.intermediate_buffer.resize(volume(ctx.shape) * type_size); | ||
| decode_out = {res.intermediate_buffer.data(), ctx.shape, ctx.pixel_type}; | ||
| } | ||
| auto decode_out = out; |
There was a problem hiding this comment.
removed try/catch (handled one layer up)
szalpal
approved these changes
Sep 26, 2022
The other try/catch is already in place. This one is redundant at this point. |
|
!build |
|
CI MESSAGE: [6012177]: BUILD STARTED |
|
CI MESSAGE: [6012177]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [6012360]: BUILD STARTED |
|
CI MESSAGE: [6012360]: BUILD FAILED |
mzient
reviewed
Sep 26, 2022
| result.exception = std::current_exception(); | ||
| if (is_processing_needed) { | ||
| auto multiplier = calc_bpp_adjustment_multiplier(ctx.bpp, ctx.pixel_type); | ||
| Convert(out, "HWC", opts.format, decode_out, "CHW", format, ctx.cuda_stream, {}, multiplier); |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
mzient
force-pushed
the
ImageDecoderPresteps
branch
from
4e9d0b5
to
8993f9c
Compare
|
CI MESSAGE: [6013162]: BUILD STARTED |
|
CI MESSAGE: [6013162]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joaquin Anton janton@nvidia.com
Category:
Refactoring
Description:
Additional information:
Affected modules and functionalities:
imgcodec
Key points relevant for the review:
NA
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A