[imgcodec] Fix normalization when running GPU color space conversion #4285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jantonguirao
approved these changes
Sep 26, 2022
|
!build |
|
CI MESSAGE: [6022405]: BUILD STARTED |
|
CI MESSAGE: [6022405]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [6023608]: BUILD STARTED |
|
CI MESSAGE: [6023608]: BUILD FAILED |
|
CI MESSAGE: [6023608]: BUILD PASSED |
|
!build |
|
CI MESSAGE: [6043674]: BUILD STARTED |
|
CI MESSAGE: [6043674]: BUILD PASSED |
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
Signed-off-by: Michał Staniewski <m.staniewzki@gmail.com>
staniewzki
force-pushed
the
gpu-convert-fix
branch
from
2d88f95
to
8136999
Compare
|
!build |
|
CI MESSAGE: [6055426]: BUILD STARTED |
mzient
approved these changes
Sep 30, 2022
mzient
reviewed
Sep 30, 2022
Comment on lines
+95
to
+96
| multiplier *= ConvertNorm<float>(static_cast<Input>(1)) / | ||
| ConvertNorm<float>(static_cast<Output>(1)); |
There was a problem hiding this comment.
Suggested change
| multiplier *= ConvertNorm<float>(static_cast<Input>(1)) / | |
| ConvertNorm<float>(static_cast<Output>(1)); | |
| multiplier *= ConvertNorm<double>(static_cast<Input>(1)) / | |
| ConvertNorm<double>(static_cast<Output>(1)); |
This can be done in a follow-up..
|
CI MESSAGE: [6055426]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michał Staniewski m.staniewzki@gmail.com
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
Currently, when running color space conversion in the GPU Convert, no normalization happens (I thought that the color space conversion kernel handles it...). This PR fixes the issue.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A