Add pass-through tracking to auto-pinning buffers #4294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [6026863]: BUILD STARTED |
|
CI MESSAGE: [6026863]: BUILD FAILED |
|
CI MESSAGE: [6026863]: BUILD PASSED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
force-pushed
the
follow-passthrough
branch
from
be9f480
to
48d260b
Compare
|
!build |
|
CI MESSAGE: [6034109]: BUILD STARTED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [6034120]: BUILD STARTED |
|
CI MESSAGE: [6034120]: BUILD PASSED |
awolant
approved these changes
Sep 30, 2022
mzient
reviewed
Sep 30, 2022
mzient
reviewed
Sep 30, 2022
mzient
reviewed
Sep 30, 2022
|
!build |
|
CI MESSAGE: [6077156]: BUILD STARTED |
mzient
approved these changes
Oct 3, 2022
|
CI MESSAGE: [6077156]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [6096195]: BUILD STARTED |
|
!build |
|
CI MESSAGE: [6096400]: BUILD STARTED |
|
CI MESSAGE: [6096400]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: New feature, Refactoring
Description:
Small refactor in executor - extract the backtracking of pass-through in the graph.
Originally it was used to obtain the group of tensor nodes that need to be treated
as outputs and buffered accordingly.
Use the functionality to pin the whole pass-through group when pinning a tensor.
Additional information:
Affected modules and functionalities:
Executor, graph
Key points relevant for the review:
Tests:
Make output buffers for arugment inputs to GPU operators pinned. #3728 didn't introduce additional tests for pinning, and I am not aware if we had any.
I'm not sure if we can easily observe the status of the outputs buffers outside of the operators or executor.
I might try to do something tomorrow, otherwise we will just have to observe the perf.I think I managed to write such test, inspecting the outputs of the executor for their pinnedness.
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A