Fix support for ANY_DATA in nvJPEG2K #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
mzient
approved these changes
Sep 29, 2022
18 tasks
| auto multiplier = calc_bpp_adjustment_multiplier(ctx.bpp, ctx.pixel_type); | ||
| Convert(out, "HWC", opts.format, decode_out, "CHW", format, ctx.cuda_stream, | ||
| Convert(out, "HWC", out_format, decode_out, "CHW", format, ctx.cuda_stream, |
There was a problem hiding this comment.
Can we handle this inside Convert? Doing something like:
if (out_format == DALI_ANY_DATA) {
out_format = in_format;
}
This way we handle it for all decoders, not only nvJPEG2k
jantonguirao
approved these changes
Sep 30, 2022
Signed-off-by: Joaquin Anton <janton@nvidia.com>
|
!build |
|
CI MESSAGE: [6053302]: BUILD STARTED |
|
CI MESSAGE: [6053302]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
nvJPEG2K decoder was requesting unsupported conversion to
ANY_DATAfrom the color conversion kernel. In this PR I adjust the decoder so that it doesn't attempt to convert colorspace in such caseAdditional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A