Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ROI adjustment for multi-frame inputs + some cleanup #4303

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Sep 30, 2022

Signed-off-by: Michal Zientkiewicz michalz@nvidia.com

Category:

New feature (non-breaking change which adds functionality)
Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

  • The calculation of pre-orientation ROI supports extra outer dimensions.
  • Removed unnecessary DLL_PUBLIC on an inline template function
  • ImageSource::SourceInfo() and Filename now return a null pointer if the string is empty
  • Add filename as a source info in ImageCodec tests

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Enable ROI adjustment for multi-frame inputs.

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6055376]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this Sep 30, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6055376]: BUILD PASSED

@mzient mzient merged commit 310c9bc into NVIDIA:main Sep 30, 2022
@mzient mzient mentioned this pull request Oct 4, 2022
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants