-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prune static cuda libraries DALI links with from unused archs #4317
Conversation
!build |
CI MESSAGE: [6111732]: BUILD STARTED |
CI MESSAGE: [6111732]: BUILD PASSED |
!build |
CI MESSAGE: [6116431]: BUILD STARTED |
docker/Dockerfile
Outdated
@@ -28,6 +28,12 @@ RUN pip install future setuptools wheel clang flake8 && \ | |||
|
|||
RUN ldconfig | |||
|
|||
RUN nvprune -gencode arch=compute_35,code=sm_35 -gencode arch=compute_50,code=sm_50 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do the same with libcufft_static.a
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry but not really. It is more complicated.
CI MESSAGE: [6116431]: BUILD PASSED |
!build |
CI MESSAGE: [6117312]: BUILD STARTED |
CI MESSAGE: [6117312]: BUILD FAILED |
!build |
CI MESSAGE: [6117712]: BUILD STARTED |
Only 5 MB, but still something. |
CI MESSAGE: [6117712]: BUILD PASSED |
69fdfc0
to
b4fa35e
Compare
CI MESSAGE: [6119846]: BUILD STARTED |
CI MESSAGE: [6119849]: BUILD STARTED |
CI MESSAGE: [6119849]: BUILD FAILED |
CI MESSAGE: [6119846]: BUILD FAILED |
- prune static cuda libraries DALI links with from unused architectures so there is no device code linked with DALI other than 35, 50, 60, 70, 80 and 90. In result the DALI wheel is a bit smaller - this PR affects only dockerized builds Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
CI MESSAGE: [6120802]: BUILD STARTED |
CI MESSAGE: [6120806]: BUILD STARTED |
CI MESSAGE: [6120806]: BUILD FAILED |
CI MESSAGE: [6120802]: BUILD FAILED |
CI MESSAGE: [6120802]: BUILD PASSED |
…NVIDIA#4317)" This reverts commit a507066.
architectures so there is no device code linked with DALI
other than 35, 50, 60, 70, 80 and 90. In result the DALI wheel
is a bit smaller
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
architectures so there is no device code linked with DALI
other than 35, 50, 60, 70, 80 and 90. In result the DALI wheel
is a bit smaller
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A