Don't use nvjpegGetHardwareDecoderInfo in pre-11.9 NVJPEG #4325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
commented
Oct 10, 2022
| #if NVJPEG_VER_MAJOR > 11 || \ | ||
| (NVJPEG_VER_MAJOR == 11 && (NVJPEG_VER_MINOR > 4 || \ | ||
| (NVJPEG_VER_MINOR == 4 && NVJPEG_VER_PATCH >= 1))) | ||
| #define NVJPEG_FLAT_VERSION(major, minor, patch) ((major)*1000000+(minor)*1000+(patch)) |
There was a problem hiding this comment.
Compute a flattened version that's easier to compare.
JanuszL
approved these changes
Oct 10, 2022
|
CI MESSAGE: [6136182]: BUILD STARTED |
jantonguirao
approved these changes
Oct 10, 2022
|
CI MESSAGE: [6136182]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Zientkiewicz michalz@nvidia.com
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
With CUDA toolkit 11.8 comes NVJPEG 11.9 which introduces a new function. While we check for its presence at run-time, we don't do it at compile time, rendering NVJPEG decoder not-compilable with older 11.x toolkits.
This PR fixes the issue.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A