Add warning about the end of support for CUDA 10.2 #4334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
|
CI MESSAGE: [6157583]: BUILD STARTED |
JanuszL
approved these changes
Oct 12, 2022
|
CI MESSAGE: [6157583]: BUILD PASSED |
stiepan
commented
Oct 12, 2022
dali/python/nvidia/dali/backend.py
Outdated
| @@ -51,6 +51,11 @@ def deprecation_warning(what): | |||
| "The next release will support only 10.2 from 10.x familly. " | |||
| "Please update your environment to CUDA version 10.2 or newer.") | |||
|
|
|||
| if __cuda_version__ < 110: | |||
There was a problem hiding this comment.
Oh, so actually for 102 build it says __cuda_version__ = 10289
JanuszL
approved these changes
Oct 12, 2022
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
|
CI MESSAGE: [6158413]: BUILD STARTED |
|
!build |
|
CI MESSAGE: [6158852]: BUILD STARTED |
|
CI MESSAGE: [6158413]: BUILD PASSED |
|
CI MESSAGE: [6158852]: BUILD PASSED |
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
stiepan
commented
Oct 13, 2022
Comment on lines
-50
to
-52
| deprecation_warning("DALI 1.3 is the last official release that supports CUDA 10.0. " | ||
| "The next release will support only 10.2 from 10.x familly. " | ||
| "Please update your environment to CUDA version 10.2 or newer.") |
There was a problem hiding this comment.
This was a dead code as the __cuda_version__ is build time thingy and we don't build with cuda 10.0.
szalpal
approved these changes
Oct 13, 2022
|
CI MESSAGE: [6168732]: BUILD STARTED |
|
CI MESSAGE: [6168732]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kamil Tokarski ktokarski@nvidia.com
Category:
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A