Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order of access order waiting in TL's set_order #4338

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

stiepan
Copy link
Member

@stiepan stiepan commented Oct 12, 2022

Signed-off-by: Kamil Tokarski ktokarski@nvidia.com

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

When the order of TL changes, the future work in new order should wait for whatever non-completed work has been scheduled in previous order, not the other way round. See buffer's set_order.

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan
Copy link
Member Author

stiepan commented Oct 12, 2022

!build

@klecki klecki self-assigned this Oct 12, 2022
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6160180]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6160180]: BUILD FAILED

@stiepan
Copy link
Member Author

stiepan commented Oct 13, 2022

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6168691]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6168691]: BUILD FAILED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [6168691]: BUILD PASSED

@stiepan stiepan merged commit 68236b6 into NVIDIA:main Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants