Prevent obtaining handle values from dead unique handles and stream leases. #4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
jantonguirao
approved these changes
Oct 13, 2022
klecki
approved these changes
Oct 13, 2022
|
CI MESSAGE: [6171060]: BUILD STARTED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [6171119]: BUILD STARTED |
klecki
reviewed
Oct 13, 2022
include/dali/core/cuda_stream_pool.h
Outdated
| } | ||
|
|
||
| /** | ||
| * @brief Cannot obtain a valie handle from a temporary CUDAStreamLease |
There was a problem hiding this comment.
Suggested change
| * @brief Cannot obtain a valie handle from a temporary CUDAStreamLease | |
| * @brief Cannot obtain a valid handle from a temporary CUDAStreamLease |
klecki
reviewed
Oct 13, 2022
klecki
reviewed
Oct 13, 2022
klecki
reviewed
Oct 13, 2022
| */ | ||
| constexpr handle_type get() && = delete; | ||
|
|
||
| /// @brief Make the wrapper usable in most context in which the handle type can be used |
There was a problem hiding this comment.
Suggested change
| /// @brief Make the wrapper usable in most context in which the handle type can be used | |
| /** | |
| * @brief Make the wrapper usable in most context in which the handle type can be used | |
| */ |
klecki
reviewed
Oct 13, 2022
| /** | ||
| * @brief Cannot obtain a valie handle from a temporary CUDAStreamLease | ||
| * | ||
| * By the time this function returns, the stream is returned to the pool. |
There was a problem hiding this comment.
I wonder, if we are at this, we should probably mention, that the user of this API should keep the StreamLease for the duration the stream is used.
There was a problem hiding this comment.
The class description describes the object life cycle.
|
CI MESSAGE: [6171119]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michal Zientkiewicz michalz@nvidia.com
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
Prevents the API user from obtaining a dead handle value from
UniqueHandleandCUDAStreamLeaseby deleting r-value-qualified overloads.Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Tested locally that the misusing code doesn't compile.
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A