Fix coverity issues #4349
Merged
Fix coverity issues #4349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rafal <rbanas@nvidia.com>
|
CI MESSAGE: [6171593]: BUILD STARTED |
mzient
reviewed
Oct 13, 2022
|
CI MESSAGE: [6171593]: BUILD PASSED |
|
CI MESSAGE: [6180197]: BUILD STARTED |
mzient
reviewed
Oct 14, 2022
dali/imgcodec/util/convert.cc
Outdated
Comment on lines
29
to
30
| DALI_ENFORCE(in_layout.find('H') >= 0 && in_layout.find('W') >= 0, | ||
| "Input layout has to contain at least H and W dimensions."); |
There was a problem hiding this comment.
Nitpick: technically, there's no such requirement for the input layout (it could be **C or whatever).
mzient
reviewed
Oct 14, 2022
dali/imgcodec/util/convert.cc
Outdated
Comment on lines
31
to
32
| DALI_ENFORCE(out_layout.find('H') >= 0 && out_layout.find('W') >= 0, | ||
| "Output layout has to contain at least H and W dimensions."); |
There was a problem hiding this comment.
I guess at this point it should be:
Suggested change
| DALI_ENFORCE(out_layout.find('H') >= 0 && out_layout.find('W') >= 0, | |
| "Output layout has to contain at least H and W dimensions."); | |
| int h_dim = ImageLayoutInfo::DimIndex(out_layout, 'H'); | |
| int w_dim = ImageLayoutInfo::DimIndex(out_layout, 'W'); | |
| DALI_ENFORCE(h_dim >= 0 && w_dim >= 0, | |
| "Output layout has to contain at least H and W dimensions."); |
...and you could remove the
auto h_dim = ImageLayoutInfo::DimIndex(out_layout, 'H');
auto w_dim = ImageLayoutInfo::DimIndex(out_layout, 'W');
from the TYPE_SWITCH below.
mzient
approved these changes
Oct 14, 2022
|
CI MESSAGE: [6180197]: BUILD PASSED |
Signed-off-by: Rafal <rbanas@nvidia.com>
|
CI MESSAGE: [6181826]: BUILD STARTED |
|
CI MESSAGE: [6181826]: BUILD PASSED |
szalpal
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rafal rbanas@nvidia.com
Category:
Bug fix
Description:
It fixes issues found by coverity
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A