-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release buffered libaviutil packets #4682
Conversation
- certain libaviutils functions that read the video packets buffers it for further use. As DALI keeps libaviutils context for each video file it processes it may lead to unnecessarily high memory consumption. This PR releases the buffered packets when the iteration with the file ends. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
!build |
CI MESSAGE: [7462821]: BUILD STARTED |
CI MESSAGE: [7462821]: BUILD FAILED |
CI MESSAGE: [7462821]: BUILD PASSED |
Can you put this pr in v1.24.0 or v1.23.1, and have a realse ? |
Hi @zsz00, We don't plan to release 1.23.1, but it should make into 1.24. In the mean time, you can try out the nightly build created after the change has been merged. |
xxx@VM-1-8-ubuntu:~$ pip install --extra-index-url https://developer.download.nvidia.com/compute/redist/nightly --upgrade nvidia-dali-nightly-cuda110 nvidia_dali_nightly_cuda110-1.24.0.dev20230223-7399572 Is this the latest nightly build ?? |
Hi @zsz00, Yes, this is the latest available for now. Due to other issues, the CI test didn't pass so the nightly hasn't been published since then. We hope to have working nightly available soon. |
Ok, I will wait for it. |
Is nightly available now ? |
I see one from 3/9 for cuda12, buf for CUDA11 the last successful one is from 2/22. |
- certain libaviutils functions that read the video packets buffers it for further use. As DALI keeps libaviutils context for each video file it processes it may lead to unnecessarily high memory consumption. This PR releases the buffered packets when the iteration with the file ends. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
buffers it for further use. As DALI keeps libaviutils context
for each video file it processes it may lead to unnecessarily
high memory consumption. This PR releases the buffered packets
when the iteration with the file ends.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
buffers it for further use. As DALI keeps libaviutils context
for each video file it processes it may lead to unnecessarily
high memory consumption. This PR releases the buffered packets
when the iteration with the file ends.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A