Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename as_param to mag_to_param #4710

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Conversation

stiepan
Copy link
Member

@stiepan stiepan commented Mar 14, 2023

Category:

Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

Renames the as_param parameter.

Additional information:

Affected modules and functionalities:

The auto_aug module and its tests

Key points relevant for the review:

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan
Copy link
Member Author

stiepan commented Mar 14, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7578954]: BUILD STARTED

@awolant awolant self-assigned this Mar 14, 2023
@klecki klecki self-assigned this Mar 14, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan
Copy link
Member Author

stiepan commented Mar 14, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7580132]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7580132]: BUILD PASSED

@stiepan stiepan merged commit 01efc24 into NVIDIA:main Mar 14, 2023
stiepan added a commit that referenced this pull request Mar 14, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
aderylo pushed a commit to zpp-dali-2022/DALI that referenced this pull request Mar 17, 2023
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@JanuszL JanuszL mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants