Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bool support in the numpy reader operator #4745

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 27, 2023

  • adds bool support for the numpy reader operator
    and adds appropriate tests

Category:

New feature (non-breaking change which adds functionality)

Description:

Additional information:

Affected modules and functionalities:

  • numpy readfer

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
      • readers/test_numpy.py
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

- adds bool support for the numpy reader operator
  and adds appropriate tests

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Mar 27, 2023

!build

@klecki klecki self-assigned this Mar 27, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7724050]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [7724050]: BUILD PASSED

@JanuszL JanuszL merged commit e68236e into NVIDIA:main Mar 29, 2023
@JanuszL JanuszL deleted the add_bool_numpy_reader branch March 29, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants