Add CPU filter operator #4764
Merged
Add CPU filter operator #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
|
!build |
|
CI MESSAGE: [7802021]: BUILD STARTED |
|
CI MESSAGE: [7802021]: BUILD PASSED |
awolant
approved these changes
Apr 4, 2023
banasraf
approved these changes
Apr 5, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
This PR adds CPU backend to the
expermimental.filteroperator. The backend simply wraps opencv's filter2d. For this reason, the volumteric data is not supported by the CPU backend, similarily input of int8 and float16 types are not supported.Both "same" and "valid" modes are supported, the first with all supported border modes.
Additional information:
Due to limitations of OCV, the constant and wrap border modes must have been implemented with extra calls to manually pad the input with proper border.
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: FILTER.01 (FILTER.01-FILTER.04, FILTER.06-FILTER.12)
JIRA TASK: DALI-3263