Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Numba CPU tests on AARCH64. #4862

Merged
merged 2 commits into from
May 22, 2023

Conversation

mzient
Copy link
Contributor

@mzient mzient commented May 22, 2023

Category:

Other (Tests, Configuration)

Description:

As of Numba 0.57 / llvmlite-0.41 there's a bug in LLVM 14 that makes dynamic JIT linking fail randomly on AARCH64. This PR temporarily disables Numba CPU tests on AARCH64 platform.

Additional information:

Related issue:
numba/numba#8567

Affected modules and functionalities:

Numba CPU tests.

Key points relevant for the review:

Tests:

test_numba_func.py

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@JanuszL JanuszL self-assigned this May 22, 2023
# At present (as of Numba 0.57) there's a bug in LLVM JIT linker that makes the tests fail
# randomly on 64-bit ARM platform.
#
# TODO(michalz): Update the Numba version range when there's a fix - or possibly check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link the relevant issue for the reference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@NVIDIA NVIDIA deleted a comment from dali-automaton May 22, 2023
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@NVIDIA NVIDIA deleted a comment from dali-automaton May 22, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8369763]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this May 22, 2023
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [8369763]: BUILD PASSED

@mzient mzient merged commit 74f1592 into NVIDIA:main May 22, 2023
4 checks passed
@mzient mzient changed the title Disasble Numba CPU tests on AARCH64. Disable Numba CPU tests on AARCH64. May 22, 2023
JanuszL pushed a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
* Disable Numba CPU tests on AARCH64.

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>

---------

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants