-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Numba CPU tests on AARCH64. #4862
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
JanuszL
approved these changes
May 22, 2023
JanuszL
reviewed
May 22, 2023
# At present (as of Numba 0.57) there's a bug in LLVM JIT linker that makes the tests fail | ||
# randomly on 64-bit ARM platform. | ||
# | ||
# TODO(michalz): Update the Numba version range when there's a fix - or possibly check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please link the relevant issue for the reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
CI MESSAGE: [8369763]: BUILD STARTED |
jantonguirao
approved these changes
May 22, 2023
JanuszL
approved these changes
May 22, 2023
CI MESSAGE: [8369763]: BUILD PASSED |
mzient
changed the title
Disasble Numba CPU tests on AARCH64.
Disable Numba CPU tests on AARCH64.
May 22, 2023
JanuszL
pushed a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
* Disable Numba CPU tests on AARCH64. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com> --------- Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other (Tests, Configuration)
Description:
As of Numba 0.57 / llvmlite-0.41 there's a bug in LLVM 14 that makes dynamic JIT linking fail randomly on AARCH64. This PR temporarily disables Numba CPU tests on AARCH64 platform.
Additional information:
Related issue:
numba/numba#8567
Affected modules and functionalities:
Numba CPU tests.
Key points relevant for the review:
Tests:
test_numba_func.py
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A