Fix coverity issues - July 2023 #4948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the check in DefaultHostResource creation, to skip the action for 0-threshold. Otherwise the condition was always true for unsigned values. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [9014708]: BUILD STARTED |
|
CI MESSAGE: [9014708]: BUILD FAILED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
CI MESSAGE: [9017007]: BUILD STARTED |
|
CI MESSAGE: [9017007]: BUILD FAILED |
szalpal
approved these changes
Jul 19, 2023
mzient
approved these changes
Jul 19, 2023
|
CI MESSAGE: [9040508]: BUILD STARTED |
|
CI MESSAGE: [9040508]: BUILD PASSED |
JanuszL
pushed a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
Adjust the check in DefaultHostResource creation, to skip the action for 0-threshold. Otherwise the condition was always true for unsigned values. Fix uninitialized value in checkpointing test. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix
Description:
Adjust the check in DefaultHostResource creation, to skip the action for 0-threshold. Otherwise the condition was always true for unsigned values.
Fix uninitialized value in checkpointing test.
Additional information:
Affected modules and functionalities:
mm, checkpointing tests.
Key points relevant for the review:
Tests:
The individual resources are tested, but I don't see case for the 0-threshold to be specifically tested.
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A