Remove the direct use of cuda_for_dali auxiliary namespace. #4953
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
Due to conflicts with libcu++, the dependence on a libcu++ fork was removed and the relevant files were copied to DALI and their contents moved to an auxiliary namespace. The direct use of this auxiliary namespace leaks a technical workaround into DALI source base.
This PR imports the relevant symbols into namespace
dali::mm
and the usages ofcuda_for_dali::
are replaced withmm::
.Additionally, some memory kind queries are replaced with a helper trait
is_host_accessible
, which was already there (it's been removed frommm::detail
tomm
).Additional information:
Affected modules and functionalities:
Memory managment headers and some random files affected by the previous workaround.
Key points relevant for the review:
N/A
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A