Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the direct use of cuda_for_dali auxiliary namespace. #4953

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Jul 25, 2023

Category:

Refactoring (Redesign of existing code that doesn't affect functionality)

Description:

Due to conflicts with libcu++, the dependence on a libcu++ fork was removed and the relevant files were copied to DALI and their contents moved to an auxiliary namespace. The direct use of this auxiliary namespace leaks a technical workaround into DALI source base.
This PR imports the relevant symbols into namespace dali::mm and the usages of cuda_for_dali:: are replaced with mm::.
Additionally, some memory kind queries are replaced with a helper trait is_host_accessible, which was already there (it's been removed from mm::detail to mm).

Additional information:

Affected modules and functionalities:

Memory managment headers and some random files affected by the previous workaround.

Key points relevant for the review:

N/A

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@mzient mzient force-pushed the memory_resource_cleanup branch 2 times, most recently from 6b330ff to 8b3d6b7 Compare July 25, 2023 08:37
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9100392]: BUILD STARTED

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9100846]: BUILD STARTED

Copy link
Member

@szalpal szalpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one remark I DM'ed

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9100846]: BUILD PASSED

@mzient mzient merged commit 4d22fa9 into NVIDIA:main Jul 25, 2023
4 checks passed
JanuszL pushed a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
)

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants