Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Stride to Subscript and Slice Kernel #5007

Merged
merged 25 commits into from
Aug 24, 2023
Merged

Added Stride to Subscript and Slice Kernel #5007

merged 25 commits into from
Aug 24, 2023

Commits on Aug 22, 2023

  1. add docker-build folder to gitignore, clang-format slice_cpu.h, level… 

    … 1 slicekernel uses strides to iterate

Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    0152190 View commit details
    Browse the repository at this point in the history

  2. clang-format + black format, removed slice notimpl errors 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a9f7387 View commit details
    Browse the repository at this point in the history

  3. add step to slice args, multiply in stride by step, clang-format 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    898ba89 View commit details
    Browse the repository at this point in the history

  4. update defauly pyver and add new runtime images 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d2cc8e6 View commit details
    Browse the repository at this point in the history

  5. fix build script 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    a936d16 View commit details
    Browse the repository at this point in the history

  6. added .devcontainer and dockerfile 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    c84adfb View commit details
    Browse the repository at this point in the history

  7. remove deps post-compile, move pre-commit install 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    53fce55 View commit details
    Browse the repository at this point in the history

  8. added more devcontainer components, add step arg (can't easily handle… 

    … anchor and stride modification), fix regression subscript.cc bad types, fix hi/lo anchor logic for negative stride, passes operator_2 tests, temp ommit gpu indexing test

Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    5eec656 View commit details
    Browse the repository at this point in the history

  9. step > 1 works (-ve not), add nsight to devctr 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    734f5cd View commit details
    Browse the repository at this point in the history

  10. Add nvjpeg2k and nvcomp to image 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    170df2f View commit details
    Browse the repository at this point in the history

  11. remove dimension inlining and anchor embedding to enable stepping to … 

    …work properly, all tests passing

Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    996d88d View commit details
    Browse the repository at this point in the history

  12. fix default values for step to be 1, clang-format 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    aeec1f2 View commit details
    Browse the repository at this point in the history

  13. add more tests for hi/lo, fix last element logic for reverse stride 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    32f8471 View commit details
    Browse the repository at this point in the history

  14. added more tests, updated docs 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    831c572 View commit details
    Browse the repository at this point in the history

  15. remove devcontainer and revert docker/build.sh 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    51168dc View commit details
    Browse the repository at this point in the history

  16. re-added dimension flattening with fixed logic + conditions 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    d9c9553 View commit details
    Browse the repository at this point in the history

  17. re-added slicenopad flatten w/ step + anchor cond 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    55cc4a7 View commit details
    Browse the repository at this point in the history

  18. preapply anchor and step if no padding 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z @mzient
    5had3z authored and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    b00063c View commit details
    Browse the repository at this point in the history

  19. Update dali/kernels/slice/slice_kernel_utils.h 

    Co-authored-by: Michał Zientkiewicz <mzient@gmail.com>
    @5had3z @mzient
    5had3z and mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    e30c269 View commit details
    Browse the repository at this point in the history

  20. Add UnitCubeShape utility. 

    Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
    @mzient
    mzient committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    3c0f993 View commit details
    Browse the repository at this point in the history

  21. added helper function to TensorShape to create filled tensor 

    Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z
    5had3z committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    948639d View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2023

  1. fix assertions, fix missing template param for ndim, removed unnessec… 

    …ary template for dynamic specialisation, remove wrong comment

Signed-off-by: Bryce Ferenczi <frenzi@hotmail.com.au>
    @5had3z
    5had3z committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    fe0ac97 View commit details
    Browse the repository at this point in the history

  2. Simplify step alongside anchor and shape. 

    Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
    @mzient
    mzient committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    c9ac7a8 View commit details
    Browse the repository at this point in the history

  3. Add a targetted test for collapsing untouched dims. 

    Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
    @mzient
    mzient committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    8e372b2 View commit details
    Browse the repository at this point in the history

  4. Restore formatting and comments. 

    Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
    @mzient
    mzient committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    6d0fcc0 View commit details
    Browse the repository at this point in the history