Add opt-in support for case insensitive webdataset #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the current implementation of webdataset is case-sensitive when it comes to file extensions. This PR adds an option to make it case insensitive when it comes to provided by the user extensions as well as the file extensions in the container Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
case_insens_webdata
branch
from
56c4359
to
dadef03
Compare
|
CI MESSAGE: [9482491]: BUILD STARTED |
|
CI MESSAGE: [9482491]: BUILD PASSED |
stiepan
reviewed
Aug 24, 2023
stiepan
reviewed
Aug 24, 2023
stiepan
reviewed
Aug 24, 2023
JanuszL
force-pushed
the
case_insens_webdata
branch
from
6f8678a
to
db6c45d
Compare
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
case_insens_webdata
branch
from
db6c45d
to
5416660
Compare
|
CI MESSAGE: [9497185]: BUILD STARTED |
stiepan
reviewed
Aug 24, 2023
JanuszL
force-pushed
the
case_insens_webdata
branch
from
908291b
to
ced1dc2
Compare
|
CI MESSAGE: [9497235]: BUILD STARTED |
stiepan
approved these changes
Aug 24, 2023
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
case_insens_webdata
branch
from
ced1dc2
to
aad8cc0
Compare
stiepan
approved these changes
Aug 24, 2023
|
CI MESSAGE: [9497235]: BUILD PASSED |
banasraf
approved these changes
Aug 25, 2023
|
CI MESSAGE: [9511524]: BUILD STARTED |
|
CI MESSAGE: [9511524]: BUILD PASSED |
JanuszL
added a commit
to JanuszL/DALI
that referenced
this pull request
Oct 13, 2023
- the current implementation of webdataset is case-sensitive when it comes to file extensions. This PR adds an option to make it case insensitive when it comes to provided by the user extensions as well as the file extensions in the container Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it comes to file extensions. This PR adds an option to make
it case insensitive when it comes to provided by the user extensions
as well as the file extensions in the container
Category:
New feature (non-breaking change which adds functionality)
Description:
it comes to file extensions. This PR adds an option to make
it case insensitive when it comes to provided by the user extensions
as well as the file extensions in the container
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: RDWDS.26
JIRA TASK: N/A