Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the way the input operators are traversed during the pipeline shutdown #5036

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Sep 4, 2023

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • makes the input operator traversal independent of their name during
    Pipeline shutdown (to allow any input operator that may want to break
    out and shutdown gracefully)

Additional information:

Affected modules and functionalities:

  • pipeline

Key points relevant for the review:

  • any test that can be added

Tests:

  • Existing tests apply
    • test_external_source_dali.py
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

…shutdown

- makes the input operator traversal independent of their name during
  Pipeline shutdown (to allow any input operator that may want to break
  out and shutdown gracefully)

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Sep 4, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9645503]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [9645503]: BUILD PASSED

@JanuszL JanuszL merged commit ae161a4 into NVIDIA:main Sep 5, 2023
5 checks passed
@JanuszL JanuszL deleted the fix_traversal branch September 5, 2023 11:36
JanuszL added a commit to JanuszL/DALI that referenced this pull request Oct 13, 2023
…shutdown (NVIDIA#5036)

- makes the input operator traversal independent of their name during
  Pipeline shutdown (to allow any input operator that may want to break
  out and shutdown gracefully)

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants