Make sure that the relase of python memory from the DALI tensor happens inside GIL #5101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
|
CI MESSAGE: [10306640]: BUILD STARTED |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| arr = np.random.rand(3, 5, 6) | ||
| tensor = TensorCPU(arr, "NHWC") | ||
| assert_array_equal(arr, np.array(tensor)) | ||
| arr = None |
Check notice
Code scanning / CodeQL
Unused local variable Note
| tensor = TensorCPU(arr, "NHWC") | ||
| assert_array_equal(arr, np.array(tensor)) | ||
| arr = None | ||
| tensor = None |
Check notice
Code scanning / CodeQL
Unused local variable Note
…ns inside GIL - no-copy mode of the DALI tensor constructor keeps an internal reference to the python object. When the Tensor is released it needs to happen inside GIL as it touches the reference count. This PR makes sure that the GIL is acquired. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [10306640]: BUILD PASSED |
jantonguirao
approved these changes
Oct 18, 2023
klecki
approved these changes
Oct 18, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to the python object. When the Tensor is released it needs to happen
inside GIL as it touches the reference count. This PR makes sure
that the GIL is acquired.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
to the python object. When the Tensor is released it needs to happen
inside GIL as it touches the reference count. This PR makes sure
that the GIL is acquired.
Relegates to #5072
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3668