Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type annotations for numba and pytorch plugins #5129

Merged
merged 10 commits into from
Nov 8, 2023
Merged

Add type annotations for numba and pytorch plugins #5129

merged 10 commits into from
Nov 8, 2023

Commits on Nov 8, 2023

  1. Reorganize plugins to reflect actual module hierarchy 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

WIP

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

WIP

Continue with numba function

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Numba and python

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Torch Python Functon

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Move annotations around

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Minor revisions

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Write tests for pytorch, extend TorchFunction overload

Fixup the None return in Python Functions (Sequence doesn't count here).

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Adjust the type of required return type in the PythonFunction callback

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>

Extend tests

Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b372614 View commit details
    Browse the repository at this point in the history

  2. Silence warning 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    199fe2c View commit details
    Browse the repository at this point in the history

  3. WIP numba 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9053d33 View commit details
    Browse the repository at this point in the history

  4. Add a test for numba 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    1b8ee88 View commit details
    Browse the repository at this point in the history

  5. Filtering the tests 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    ce3d618 View commit details
    Browse the repository at this point in the history

  6. LiNT 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    d2ddb38 View commit details
    Browse the repository at this point in the history

  7. Silience mypy warning for pytorch 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    f2b1b38 View commit details
    Browse the repository at this point in the history

  8. Add mypy to pytorch tests 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a106e84 View commit details
    Browse the repository at this point in the history

  9. Cleanup 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    4611987 View commit details
    Browse the repository at this point in the history

  10. LINT 

    Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
    @klecki
    klecki committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    e0b7772 View commit details
    Browse the repository at this point in the history