Fix exit sequence. #5138
Merged
Fix exit sequence. #5138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that memory resources are ready when the pipeline is created; Register a python atexit handler that shuts down the pipelines. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
mzient
added
the
important-fix
|
CI MESSAGE: [10556356]: BUILD STARTED |
JanuszL
reviewed
Nov 2, 2023
JanuszL
approved these changes
Nov 2, 2023
JanuszL
approved these changes
Nov 2, 2023
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
JanuszL
approved these changes
Nov 2, 2023
|
CI MESSAGE: [10556871]: BUILD STARTED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [10556906]: BUILD STARTED |
klecki
reviewed
Nov 2, 2023
klecki
reviewed
Nov 2, 2023
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
szalpal
approved these changes
Nov 2, 2023
Comment on lines
23
to
27
| def test_shutdown(): | ||
| global p | ||
| p = pipeline(device_id=None) | ||
| p.build() | ||
| p.run() |
There was a problem hiding this comment.
Does this test case fail without the fix? If not, maybe some better test would be suitable?
There was a problem hiding this comment.
It doesn't "fail". The script crashes at exit.
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [10557658]: BUILD STARTED |
|
CI MESSAGE: [10557763]: BUILD STARTED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
CI MESSAGE: [10559980]: BUILD STARTED |
JanuszL
reviewed
Nov 2, 2023
Comment on lines
+1506
to
+1509
| if p is None: | ||
| Pipeline._pipes.discard(weak) | ||
| continue | ||
| p._shutdown() |
There was a problem hiding this comment.
Will that work as well?
Suggested change
| if p is None: | |
| Pipeline._pipes.discard(weak) | |
| continue | |
| p._shutdown() | |
| if p is not None: | |
| p._shutdown() |
|
CI MESSAGE: [10559980]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register a python atexit handler that shuts down the pipelines.
Fix host resource cleanup.
Improve Pipeline shutdown sequence; ensure that memory resources are ready when the pipeline is created
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
The bug: when using PythonFunction operator, the shutdown sequence was somehow broken and the pipeline was still running when the interpreter was already torn down and some libraries were unloaded.
The fix:
Register a python atexit handler that shuts down the pipelines.
Fix host resource cleanup.
Improve Pipeline shutdown sequence; ensure that memory resources are ready when the pipeline is created
Additionally (I don't know how necessary this is, after all) - got rid of static variables when creating host default resource.
Additional information:
Affected modules and functionalities:
Pipeline (C++ and Python)
Default resources.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3673