Improve checkpointing docs #5142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
mzient
approved these changes
Nov 3, 2023
stiepan
reviewed
Nov 3, 2023
dali/python/nvidia/dali/pipeline.py
Outdated
|
|
||
| p = pipeline() | ||
| p.build() | ||
| # Run the pipeline... |
There was a problem hiding this comment.
nitpick: At first I thought the Run the pipeline refers to the line below, where we save the checkpoint. Maybe adding p.run() or even some for loop to make the example more explicit would help disambiguate it?
Or mabe it's just me.
There was a problem hiding this comment.
Good point, I changed it to explicitly running p.run()
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
awolant
approved these changes
Nov 3, 2023
|
!build |
|
CI MESSAGE: [10599547]: BUILD STARTED |
|
CI MESSAGE: [10599547]: BUILD FAILED |
|
!build |
|
CI MESSAGE: [10606677]: BUILD STARTED |
|
CI MESSAGE: [10606677]: BUILD PASSED |
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
szkarpinski
force-pushed
the
checkpoint-docs
branch
from
d1909ca
to
fcb602a
Compare
|
!build |
|
CI MESSAGE: [10608374]: BUILD STARTED |
|
CI MESSAGE: [10608374]: BUILD FAILED |
|
CI MESSAGE: [10608374]: BUILD PASSED |
stiepan
pushed a commit
that referenced
this pull request
Nov 6, 2023
Checkpointing docs were updated and extended with a small example --------- Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other - Documentation
Description:
enable_memory_statsdocsAdditional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A