Fix Python Functions ops signature #5143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameters are not keyword-only. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [10583536]: BUILD STARTED |
|
CI MESSAGE: [10583536]: BUILD FAILED |
banasraf
approved these changes
Nov 6, 2023
szalpal
approved these changes
Nov 6, 2023
mzient
approved these changes
Nov 6, 2023
|
CI MESSAGE: [10583536]: BUILD PASSED |
stiepan
pushed a commit
that referenced
this pull request
Nov 6, 2023
The parameters are not keyword-only as is the case for the dynamically generated APIs. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix
Description:
The parameters are not keyword-only as is the case for the dynamically
generated APIs. The wrong annotation is not a critical bug - it doesn't affect
runtime and it is more strict than the actual one.
Additional information:
Affected modules and functionalities:
Python Function annotations for ops API.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A