Improve Python Function signature annotation #5149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return type requires a Tuple (instead of generic Sequence), a None has to be added explicitly for no output variants. Default num_outputs (equal to 1) overload is added so we can have a DataNode return type directly. Tests are reworked and extended. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
18 tasks
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [10633687]: BUILD STARTED |
|
CI MESSAGE: [10633687]: BUILD PASSED |
szalpal
approved these changes
Nov 8, 2023
stiepan
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category: Bug fix, New feature
Description:
The return type of the
functionparameter passed to Python Functionoperators requires to be a Tuple (instead of generic Sequence) in case
of multiple outputs (matching typical Python semantics).
List return values are not considered as multiple outputs from the function
(as opposed to External Souce).
A
Noneannotation has to be added explicitly for no output variants.Default num_outputs (equal to 1) overload is added so we can have a DataNode
return type directly.
Tests are reworked and extended.
Additional information:
Affected modules and functionalities:
Python Function annotations.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A