Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coverity fixes: fix fn.normalize crash on batch of empty samples, fix broken assertion in copy_with_stride #5223

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Coverity fixes: fix fn.normalize crash on batch of empty samples, fix broken assertion in copy_with_stride #5223

merged 3 commits into from
Dec 7, 2023

Conversation

stiepan
Copy link
Member

@stiepan stiepan commented Dec 5, 2023 •
edited

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • Fixes division by zero issue in GPU fn.normalize when run inferring the block size for a batch of empty tensors.
  • Fixes broken assertion in copy_with_strides for dl python function

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply (test_dltensor_operator.test_pytorch in debug build for copy_with_strides fix)
  • New tests added
    • Python tests (test_normalize.test_batch_of_empty_samples)
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-3715

@stiepan
Fix broken assertion in copy with stride (fn.python_function strided …
55548ae 
…tensor copy kernel)

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan
Fix GPU fn.normalize crash on batch of empty samples
ce4f53f 
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan
Add test with empty samples for fn.normalize
c85f946 
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan stiepan marked this pull request as ready for review December 5, 2023 17:23
@stiepan
Copy link
Member Author

stiepan commented Dec 5, 2023

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11262172]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [11262172]: BUILD PASSED

@stiepan stiepan merged commit 3b53d18 into NVIDIA:main Dec 7, 2023
5 checks passed
@AtomicVar AtomicVar mentioned this pull request Dec 7, 2023
Merged
18 tasks
AtomicVar pushed a commit to AtomicVar/DALI that referenced this pull request Dec 7, 2023
@stiepan @AtomicVar
Coverity fixes: fix fn.normalize handling of batch of empty samples, …
5b4b124 
…fix broken assertion in copy_with_stride (NVIDIA#5223)

* Fix GPU fn.normalize crash on batch of empty samples
* Fix broken assertion in copy with stride (fn.python_function strided tensor copy kernel)
---------

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@AtomicVar AtomicVar mentioned this pull request Dec 7, 2023
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klecki klecki klecki approved these changes

@szkarpinski szkarpinski szkarpinski approved these changes

Assignees

@klecki klecki

@szkarpinski szkarpinski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stiepan @dali-automaton @klecki @szkarpinski