Add missing calls to nvmlShutdown #5311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- in some places, DALI initializes nvml but misses to call nvmlShutdown to shut it down gracefully Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
JanuszL
force-pushed
the
add_nvml_shutdown
branch
from
93f70ce
to
7e59bc1
Compare
|
!build |
|
CI MESSAGE: [12619731]: BUILD STARTED |
mzient
reviewed
Feb 6, 2024
Comment on lines
+207
to
211
| nvml::Init(); | ||
| static float driver_version = nvml::GetDriverVersion(); | ||
| nvml::Shutdown(); | ||
| static bool device_supports_hw_decoder = nvml::isHWDecoderSupported(); | ||
| return device_supports_hw_decoder && driver_version >= 455; |
There was a problem hiding this comment.
This is a potential perf hit.
Suggested change
| nvml::Init(); | |
| static float driver_version = nvml::GetDriverVersion(); | |
| nvml::Shutdown(); | |
| static bool device_supports_hw_decoder = nvml::isHWDecoderSupported(); | |
| return device_supports_hw_decoder && driver_version >= 455; | |
| static const float driver_version = []() { | |
| nvml::Init(); | |
| float ver = nvml::GetDriverVersion(); | |
| nvml::Shutdown(); | |
| return ver; | |
| }(); | |
| static const bool device_supports_hw_decoder = nvml::isHWDecoderSupported(); | |
| return device_supports_hw_decoder && driver_version >= 455; |
There was a problem hiding this comment.
In the hot path, I would go for something faster. This is just a test. I don't think it will affect it much.
stiepan
reviewed
Feb 6, 2024
stiepan
approved these changes
Feb 6, 2024
mzient
approved these changes
Feb 6, 2024
|
CI MESSAGE: [12619731]: BUILD PASSED |
|
Let me run with sanitizers ON as it passes the basic CI. |
|
CI MESSAGE: [12655173]: BUILD STARTED |
|
CI MESSAGE: [12655173]: BUILD FAILED |
JanuszL
added
the
important-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to call nvmlShutdown to shut it down gracefully
Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
to call nvmlShutdown to shut it down gracefully
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A