Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
This code looks like it validates that the
auto_reset
argument isTrue
,False
,"yes"
,"no"
, orNone
:But in fact the
else
clause will never trigger, because all falsy values will trigger the first branch, and all truthy values (except"no"
) will trigger the second branch. So theelse
clause is dead code.And if the user provides
"False"
or"No"
, the code will silently setself._auto_reset
to"yes"
This PR limits acceptable values to
True
,False
,"yes"
,"no"
, orNone
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A