Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use synchronous copy to framework array in the absence of a stream #5364

Merged
merged 1 commit into from Mar 11, 2024

Conversation

stiepan
Copy link
Member

@stiepan stiepan commented Mar 8, 2024

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

The mxnet does not provide stream to make the copy, in that case the copy_to_external should not be run in non-blocking mode (as it ends up doing the copy on a random stream).

Additional information:

Affected modules and functionalities:

Key points relevant for the review:

Tests:

  • Existing tests apply (mxnet/gluon checkpointing tests)
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
@stiepan
Copy link
Member Author

stiepan commented Mar 8, 2024

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13371299]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13371299]: BUILD PASSED

@stiepan stiepan merged commit 5feab83 into NVIDIA:main Mar 11, 2024
7 checks passed
stiepan added a commit that referenced this pull request Mar 11, 2024
…5364)

Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants