Improve op deprecation and deprecate sequence reader #5372
Conversation
Adjust warning and doc generation to allow for not specyfining the replacement operator. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [13489282]: BUILD STARTED |
|
CI MESSAGE: [13489282]: BUILD FAILED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
force-pushed
the
deprecate-sequence-reader
branch
from
fc8c47f
to
24839bc
Compare
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [13522094]: BUILD STARTED |
| This operator is an analogue of VideoReader working on video frames extracted as separate images. | ||
| It's main purpose is for test baseline. For regular usage, the VideoReader is | ||
| This operator is an analogue of video reader working on video frames extracted as separate images. | ||
| It's main purpose is for test baseline. For regular usage, the video reader is |
There was a problem hiding this comment.
I know it's not yours, but
| It's main purpose is for test baseline. For regular usage, the video reader is | |
| Its main purpose is for test baseline. For regular usage, the video reader is |
|
nitpick: Should we test that? Like the newly depracated operator and maybe some other example with "in_favour_of"? There's even the |
|
CI MESSAGE: [13522094]: BUILD FAILED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
klecki
changed the title
I added generic test for this, should I also add the specific one for this operator? |
|
!build |
|
CI MESSAGE: [13533890]: BUILD STARTED |
|
CI MESSAGE: [13533890]: BUILD FAILED |
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
!build |
|
CI MESSAGE: [13549970]: BUILD STARTED |
Up to you:) |
|
CI MESSAGE: [13549970]: BUILD PASSED |
Category: Other, Refactoring
Description:
Refactor the deprecation warnings so that it shows the proper, fully qualified operator name
and suggests the replacement operator in the fn API (with fully qualified name as well).
Adjust warning and doc generation to allow for not specifying the replacement operator.
Add the deprecation message to the
fn.readers.sequence.Fix the module and display name propagation for external source.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A