Support checkpointing in JAX decorators #5374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!build |
szkarpinski
commented
Mar 13, 2024
| @@ -81,7 +81,8 @@ class DALIGenericIterator(_DaliBaseIterator): | |||
| prepare_first_batch : bool, optional, default = True | |||
| Whether DALI should buffer the first batch right after the creation of the iterator, | |||
| so one batch is already prepared when the iterator is prompted for the data | |||
| sharding : ``jax.sharding.Sharding`` compatible object that, if present, will be used to | |||
| sharding : `jax.sharding.Sharding` | |||
| `jax.sharding.Sharding` compatible object that, if present, will be used to | |||
There was a problem hiding this comment.
It looked like this before:
|
CI MESSAGE: [13498814]: BUILD STARTED |
|
CI MESSAGE: [13498814]: BUILD FAILED |
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
szkarpinski
force-pushed
the
jax-iter-cpt
branch
from
a816a8b
to
2329870
Compare
jantonguirao
approved these changes
Mar 22, 2024
klecki
reviewed
Mar 22, 2024
klecki
approved these changes
Mar 22, 2024
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
|
!build |
|
CI MESSAGE: [13825594]: BUILD STARTED |
|
CI MESSAGE: [13825594]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
In this PR I add
checkpointskwarg to@data_iteratorand@peekable_data_iterator, which (if provided) is forwarded to the underlying pipelines, allowing restoring them from checkpoints.Additional information:
Affected modules and functionalities:
JAX
@data_iteratorand@peekable_data_iterator.Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: DALI-3786