-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Loader checkpointing bug #5378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
szkarpinski
added
the
important-fix
Fixes an important issue in the software or development environment.
label
Mar 18, 2024
stiepan
approved these changes
Mar 19, 2024
!build |
CI MESSAGE: [13636778]: BUILD STARTED |
CI MESSAGE: [13636778]: BUILD PASSED |
Signed-off-by: Szymon Karpiński <skarpinski@nvidia.com>
jantonguirao
approved these changes
Apr 2, 2024
!build |
CI MESSAGE: [13932924]: BUILD STARTED |
CI MESSAGE: [13932924]: BUILD FAILED |
CI MESSAGE: [13932924]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
Context
Loader
checkpointing works the following way:current_snapshot_
)age
counter of the current snapshot is incremented.When restoring from checkpoint, Loader first restores its state from the snapshot provided, and then fast-forwards
age
iterations.Bug & fix
On restore, during fast-forwarding phase, the
age
counter is increased byReadOne
, resulting in incorrect value ofage
being kept incurrent_snapshot_
. In this PR I fix the restore function to setage
to a correct value.Impact
For the first epoch after restoring from checkpoint, Loader's
current_snapshot_
will have invalidage
. As a result, checkpoints of the Loader saved during this first epoch will be incorrect. After the first epoch,age
will be reset and the checkpoints will be correct again.Additional information:
Affected modules and functionalities:
Loader checkpointing.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A