Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize: Optimize block sizes, use dynamic amount of shared mem. #5382

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

mzient
Copy link
Contributor

@mzient mzient commented Mar 19, 2024

Category:

Other Optimization

Description:

This PR fixes the low GPU utilization issue in resize kernel.
It does 3 things:

  • reduces the size of the logical block (more blocks = better occupancy)
  • reduces the size of the physical block
  • computes the amount of shared memory required dynamically instead of always requiring 32kB

Additional information:

Affected modules and functionalities:

Resize, operators derived from ResizeBase.

Key points relevant for the review:

Tests:

python/operator_2/resize_test.py
resampling kernel tests

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-3813

mzient and others added 3 commits March 19, 2024 09:53
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Signed-off-by: Kamil Tokarski <ktokarski@nvidia.com>
… shared mem size.

Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13636414]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13636414]: BUILD PASSED

@mzient mzient assigned jantonguirao and unassigned klecki Mar 20, 2024
@mzient mzient merged commit a354801 into NVIDIA:main Mar 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants