Update supported TensorFlow version #5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI MESSAGE: [13687191]: BUILD STARTED |
szalpal
approved these changes
Mar 21, 2024
JanuszL
force-pushed
the
tf_2.16
branch
2 times, most recently
from
dfb857f
to
ee400f1
Compare
|
CI MESSAGE: [13697636]: BUILD STARTED |
mzient
reviewed
Mar 21, 2024
dali_tf_plugin/daliop.cc
Outdated
Comment on lines
23
to
28
| #if TF_MAJOR_VERSION == 2 && TF_MINOR_VERSION >= 16 | ||
| #include "third_party/eigen3/unsupported/Eigen/CXX11/Tensor" | ||
| #else | ||
| #include "unsupported/Eigen/CXX11/Tensor" | ||
| #endif |
There was a problem hiding this comment.
I don't understand this piece. It seems that the new build path affects only the older versions. Before this change the only build path was the one that now seems to be restricted to the newer versions. How did it work before and why would it stop working now?
There was a problem hiding this comment.
Worked by accident. Fixed.
|
CI MESSAGE: [13697636]: BUILD FAILED |
|
CI MESSAGE: [13703523]: BUILD STARTED |
|
CI MESSAGE: [13703523]: BUILD FAILED |
|
CI MESSAGE: [13703523]: BUILD PASSED |
mzient
approved these changes
Mar 22, 2024
- removed default support for 2.14 - updates 2.15 to 2.15.1 - adds built-in support for 2.16.1 - adjusts tests for changes in TF 2.16 Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
CI MESSAGE: [13715242]: BUILD STARTED |
|
CI MESSAGE: [13715242]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other (e.g. Documentation, Tests, Configuration)
Description:
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A