Workaround ASAN bug ignoring RPATH #5388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joaquin Anton <janton@nvidia.com>
JanuszL
reviewed
Mar 21, 2024
qa/test_template_impl.sh
Outdated
| @@ -84,12 +84,16 @@ enable_sanitizer() { | |||
| gcc -shared -fPIC $topdir/qa/test_wrapper_post.c -o /tmp/post.so | |||
| export OLD_LD_PRELOAD=${LD_PRELOAD} | |||
| export LD_PRELOAD="/tmp/pre.so /usr/lib/x86_64-linux-gnu/libasan.so /tmp/glibc_fix.so /tmp/post.so /usr/lib/x86_64-linux-gnu/libstdc++.so /tmp/libfakeclose.so" | |||
| # Workaround for bug in asan ignoring RPATHs https://bugzilla.redhat.com/show_bug.cgi?id=1449604 | |||
| export OLD_LD_LIBRARY_PATH=${LD_LIBRARY_PATH} | |||
There was a problem hiding this comment.
We already use OLD_LD_LIBRARY_PATH in L140. This may collide.
|
CI MESSAGE: [13693014]: BUILD STARTED |
Signed-off-by: Joaquin Anton <janton@nvidia.com>
JanuszL
approved these changes
Mar 21, 2024
|
CI MESSAGE: [13693208]: BUILD STARTED |
|
CI MESSAGE: [13693208]: BUILD FAILED |
szalpal
approved these changes
Mar 22, 2024
|
!build |
|
CI MESSAGE: [13719133]: BUILD STARTED |
|
CI MESSAGE: [13719133]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Other
Description:
Worksaround a bug in ASAN, so that we can run our sanitizer tests
Additional information:
Affected modules and functionalities:
Sanitizer test run
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A