Use host sync allocation for nvImageCodec <= 0.2 #5391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… test_imgcodec.py changes This reverts commit b44a507. Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
commented
Mar 22, 2024
| @@ -99,94 +99,79 @@ def test_image_decoder(): | |||
|
|
|||
|
|
|||
| @pipeline_def | |||
| def create_decoder_slice_pipeline(data_path, device, is_roi_dec): | |||
| def create_decoder_slice_pipeline(data_path, device): | |||
There was a problem hiding this comment.
this is reverting the changes from b44a507
|
!build |
|
CI MESSAGE: [13715481]: BUILD STARTED |
|
CI MESSAGE: [13715481]: BUILD FAILED |
mzient
approved these changes
Mar 22, 2024
awolant
approved these changes
Mar 22, 2024
Signed-off-by: Joaquin Anton <janton@nvidia.com>
jantonguirao
force-pushed
the
host_sync_alloc_img_dec
branch
from
39f5c75
to
59901b0
Compare
|
CI MESSAGE: [13720135]: BUILD STARTED |
|
CI MESSAGE: [13720135]: BUILD PASSED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix
Description:
nvImageCodec 0.2 doesn't sync with user stream before decoding, meaning that the buffer provided needs to be ready immediately before we call decode. This limitation shall be lifted on the following version.
Additional information:
Affected modules and functionalities:
experimental image decoders
Key points relevant for the review:
N/A
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A