Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Bandit security scan #5402

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Enable Bandit security scan #5402

merged 2 commits into from
Apr 11, 2024

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Mar 28, 2024

  • enables Bandit security scan in github actions
  • makes Bandit run a part of the linting target in CMake

Signed-off-by: Janusz Lisiecki jlisiecki@nvidia.com

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • enables Bandit security scan in github actions
  • makes Bandit run a part of the linting target in CMake

Additional information:

Affected modules and functionalities:

  • CMake lint target
  • moved some scripts from tools to internal_tools (the one that are not part of the wheel)
  • updated github actions
  • added Bandit to the docker en

Key points relevant for the review:

Tests:

  • Existing tests apply
    • lint target of the build process
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@JanuszL JanuszL force-pushed the enable_bandint branch 2 times, most recently from 47f54d3 to 2a6263b Compare March 28, 2024 09:47
@JanuszL
Copy link
Contributor Author

JanuszL commented Mar 28, 2024

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13849091]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13849091]: BUILD PASSED

- enables Bandit security scan in github actions
- makes Bandit run a part of the linting target in CMake

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Apr 2, 2024

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13934395]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [13934395]: BUILD PASSED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@JanuszL
Copy link
Contributor Author

JanuszL commented Apr 10, 2024

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14137300]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14137300]: BUILD PASSED

@JanuszL JanuszL merged commit 8378c4e into NVIDIA:main Apr 11, 2024
7 checks passed
@JanuszL JanuszL deleted the enable_bandint branch April 11, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants