Changes to dali/util/numpy #5416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fversaci
added a commit
to fversaci/cassandra-dali-plugin
that referenced
this pull request
Apr 5, 2024
- Make `numpy.h` available to users - Extend `ReadTensor` to also accept a `bool pinned` argument - See NVIDIA#5337 for details Signed-off-by: Francesco Versaci <francesco.versaci@gmail.com>
|
Hi @fversaci, Thank you for your contribution. Looks good. I have one small ask - can you sign off your commit? |
Hi, I should have fixed that (via a |
|
Sweet. Thanks! |
|
!build |
|
CI MESSAGE: [14025578]: BUILD STARTED |
|
CI MESSAGE: [14025578]: BUILD PASSED |
mzient
reviewed
Apr 8, 2024
Stop using pinned-memory in CPU-only test Co-authored-by: Michał Zientkiewicz <mzient@gmail.com> Signed-off-by: Francesco Versaci <francesco.versaci@gmail.com>
banasraf
approved these changes
Apr 8, 2024
mzient
approved these changes
Apr 9, 2024
|
!build |
|
CI MESSAGE: [14101833]: BUILD STARTED |
|
CI MESSAGE: [14101833]: BUILD FAILED |
|
CI MESSAGE: [14101833]: BUILD PASSED |
fversaci
added a commit
to fversaci/cassandra-dali-plugin
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category:
New feature (non-breaking change which adds functionality)
Description:
numpy.havailable to usersReadTensorto also accept abool pinnedargumentAdditional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A