Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DALI TF plugin source compilation during installation #5448

Merged
merged 2 commits into from
Apr 30, 2024

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented Apr 29, 2024

  • removes unnecessary escape characters from compilation commands
    for the DALI TF plugin stub and binary issues when the
    plugin is built from the source during installation. Before
    this change rpatch was incorrectly set to '$ORIGIN' instead
    of just $ORIGIN

Category:

Bug fix (non-breaking change which fixes an issue)

Description:

  • removes unnecessary escape characters from compilation commands
    for the DALI TF plugin stub and binary issues when the
    plugin is built from the source during installation. Before
    this change rpatch was incorrectly set to '$ORIGIN' instead
    of just $ORIGIN

Additional information:

Affected modules and functionalities:

  • DALI TF plugin

Key points relevant for the review:

  • NA

Tests:

  • Existing tests apply
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
      • extended TL0_tensorflow_plugin
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: DALI-3955

@JanuszL
Copy link
Contributor Author

JanuszL commented Apr 29, 2024

!build

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14613019]: BUILD STARTED

- removes unnecessary escape characters from compilation commands
  for the DALI TF plugin stub and binary issues when the
  plugin is built from the source during installation. Before
  this change rpatch was incorrectly set to '$ORIGIN' instead
  of just $ORIGIN

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14613294]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14613294]: BUILD FAILED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14629131]: BUILD STARTED

@jantonguirao jantonguirao self-assigned this Apr 30, 2024
@klecki klecki self-assigned this Apr 30, 2024
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [14629131]: BUILD PASSED

@JanuszL JanuszL merged commit 80b67f9 into NVIDIA:main Apr 30, 2024
6 checks passed
@JanuszL JanuszL deleted the fix_TF_plugin_compilation branch April 30, 2024 10:47
JanuszL added a commit that referenced this pull request Apr 30, 2024
- removes unnecessary escape characters from compilation commands
  for the DALI TF plugin stub and binary issues when the
  plugin is built from the source during installation. Before
  this change rpatch was incorrectly set to '$ORIGIN' instead
  of just $ORIGIN

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants