Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to CUDA 12.5 #5478

Merged
merged 2 commits into from
May 27, 2024
Merged

Move to CUDA 12.5 #5478

merged 2 commits into from
May 27, 2024

Conversation

JanuszL
Copy link
Contributor

@JanuszL JanuszL commented May 21, 2024

  • moves to CUDA 12.5

Category:

Other (e.g. Documentation, Tests, Configuration)

Description:

  • moves to CUDA 12.5

Additional information:

Affected modules and functionalities:

  • docker files with CUDA
  • build.sh
  • compilation guide

Key points relevant for the review:

Tests:

  • Existing tests apply
    • all GPU related tests
  • New tests added
    • Python tests
    • GTests
    • Benchmark
    • Other
  • N/A

Checklist

Documentation

  • Existing documentation applies
  • Documentation updated
    • Docstring
    • Doxygen
    • RST
    • Jupyter
    • Other
  • N/A

DALI team only

Requirements

  • Implements new requirements
  • Affects existing requirements
  • N/A

REQ IDs: N/A

JIRA TASK: N/A

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15204486]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15204486]: BUILD FAILED

./cuda_*.run --silent --no-opengl-libs --toolkit && \
rm -f cuda_*.run;

RUN NVJPEG2K_VERSION=0.7.5.32-1 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that there is NVJPEG2K 0.8.0.38-1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is intentional, The newer NVJPEG2K changes one of the filed in the structure from the headers and as we use nvImageCodec build from source for Xavier/Conda it break the build. We need to wait for the new nvImageCodec release before bumping this up.

./cuda_*.run --silent --no-opengl-libs --toolkit && \
rm -f cuda_*.run;

RUN NVJPEG2K_VERSION=0.7.5.32-1 && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

docker/build.sh Outdated Show resolved Hide resolved
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15290551]: BUILD STARTED

Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15291307]: BUILD STARTED

@dali-automaton
Copy link
Collaborator

CI MESSAGE: [15291307]: BUILD PASSED

@JanuszL JanuszL merged commit a9c092b into NVIDIA:main May 27, 2024
6 checks passed
@JanuszL JanuszL deleted the cuda_12.5 branch May 27, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants