Change DALIOpType to dali::OpType enum class #597
Merged
+159
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build 662132 |
This was referenced Mar 5, 2019
klecki
force-pushed
the
dali-op-type
branch
2 times, most recently
from
eb3cbd0
to
40662fc
Compare
This was referenced Mar 5, 2019
awolant
approved these changes
Mar 6, 2019
mzient
approved these changes
Mar 6, 2019
dali/test/dali_test_matching.h
Outdated
|
|
||
|
|
||
| DALIOpType m_nOpType = DALI_GPU; | ||
| OpType m_nOpType = OpType::GPU; |
There was a problem hiding this comment.
Please get rid of m_n prefix. First of all n should be for number of which is not the case here.
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| namespace dali { | |||
|
|
|||
| typedef int64 NodeID; | |||
| using NodeID = int64_t; | |||
There was a problem hiding this comment.
I thought you were renaming it in another PR, weren't you? In that case, you may leave the typedef here and spare yourself one conflict to resolve while rebasing...
There was a problem hiding this comment.
Everything is already rebased.
|
Build 663208 |
JanuszL
approved these changes
Mar 6, 2019
Remove cpu_op(), gpu_op(), etc from OpGraph to simplify access to nodes. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
|
Build 663348 |
haoxintong
pushed a commit
to haoxintong/DALI
that referenced
this pull request
Jul 16, 2019
Remove cpu_op(), gpu_op(), etc from OpGraph to simplify access to nodes. Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove cpu_op(), gpu_op(), etc from OpGraph
to simplify access to nodes.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com