Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for L1 tests #687

Merged
merged 1 commit into from Mar 26, 2019
Merged

Fix for L1 tests #687

merged 1 commit into from Mar 26, 2019

Conversation

szalpal
Copy link
Member

@szalpal szalpal commented Mar 21, 2019

Signed-off-by: Michał Szołucha mszolucha@nvidia.com

Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal
Copy link
Member Author

szalpal commented Mar 21, 2019

@szalpal szalpal changed the title [WIP] L1 fix Fix for L1 tests Mar 21, 2019
@@ -1,4 +1,7 @@
#!/bin/bash -e

source ../setup_test.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Long run I would make this sourced inside test_template.sh.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, not all test.sh scripts use test_template.sh (i.e. defining test in test_body function). It could be unified, but is out of scope of this PR

@JanuszL JanuszL merged commit e66e794 into NVIDIA:master Mar 26, 2019
haoxintong pushed a commit to haoxintong/DALI that referenced this pull request Jul 16, 2019
Signed-off-by: Michał Szołucha <mszolucha@nvidia.com>
@szalpal szalpal deleted the L1_fix branch January 24, 2020 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants